Add ability to send remote write 2.0 requests#124
Merged
saswatamcode merged 7 commits intoprometheus-community:mainfrom Feb 28, 2025
Merged
Add ability to send remote write 2.0 requests#124saswatamcode merged 7 commits intoprometheus-community:mainfrom
saswatamcode merged 7 commits intoprometheus-community:mainfrom
Conversation
bwplotka
reviewed
Jan 21, 2025
metrics/write.go
Outdated
Comment on lines
+271
to
+276
| switch ts := any(tss).(type) { | ||
| case []*writev2.TimeSeries: | ||
| req = any(&writev2.Request{ | ||
| Timeseries: ts[i:end], | ||
| Symbols: st.Symbols(), | ||
| }).(R) |
Collaborator
Author
There was a problem hiding this comment.
Yeah was experimenting. Generics work, but result in super tricky code. I'll revert back to what I had initially
bwplotka
reviewed
Feb 3, 2025
bwplotka
reviewed
Feb 3, 2025
bwplotka
reviewed
Feb 3, 2025
Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com>
Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com>
Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com>
Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com>
Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com>
bwplotka
approved these changes
Feb 28, 2025
Member
bwplotka
left a comment
bwplotka
left a comment
There was a problem hiding this comment.
Thanks! One naming bit, otherwise LGTM (feel free to merge after rename)
Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on client_golang remote write 2.0 PR